Re: [PATCH] misc svn build errors

[ abbreviated, vacation-mode response: enabled ... :-) ]

On Wed, Sep 20, 2000 at 08:14:34AM -0700, Bob Miller wrote:
> Greg Stein wrote:
> > I was building mod_dav_svn without a problem, so I would be suspect of your
> > particular situation. What kind of problem did you observe? Did you make
> > sure to use autogen.sh after your most recent "cvs update"? That would
> > regenerate the appropriate APACHE_INCLUDES that I mentioned (by automake).
>
> The error I saw is that <httpd.h> couldn't be found. I don't have

As you found, the --with-apache switch is needed for that case (I don't
believe that I have auto-search in there yet).

> that file in /usr/include. I also observed that the compilation line
> did not say -I.../apache/.... After I made the Makefile.am change,
> these args were added to the compile command.

Hmm. They're in mine, too... without the change.

In my Makefile.in (constructed by automake), I have the following lines:

APACHE_INCLUDES = @APACHE_INCLUDES@
APACHE_MODULES = @APACHE_MODULES@

(lines 66 and 67 in my copy)

Thus, the $(APACHE_INCLUDES) works properly.

I am using automake 1.4 (RPM: automake-1.4-6). How about you?

>...
> Do you use the --with-apache= flag?

"--with-apache=/usr/local/src/apache/apache-2.0" \

> I readily admit that I don't know enough about autoconf or automake,
> and that my patch might not be the right way to fix it. But I'm
> certain the current version doesn't work. (-:

There is something subtle going on because my Makefile.in is picking up all
the right bits to make this work correctly. I'd rather continue to use
$(APACHE_INCLUDES) because that documents what is happening at that point in
the Makefile. Direct substitution loses the semantic info.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/