Re: [PATCH] Delta window changes and delta applicator
From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2000-09-19 17:14:00 CEST
Thanks for the careful review.
> Did you look at the VCDIFF->text delta declarations in
Er, right, I hadn't. But having read thad, we have two very different
* svn_txdelta() hands you a stream, and you call
* svn_vcdiff_parse() take an svn_vcdiff_parser_t, which
Having a pull-style interface for one function and a push-style
>> I also wrote some wrappers for full reads and full writes,
> IMO it would be better to impose that restriction on the generic
That's fine with me if it's fine with other people.
>> +#ifndef MAX
> I must say I absolutely hate seeing min/max macros [...]
I'm not too enamored of them either. I'll look for alternatives along
> (BTW, you put "int new_size" in the bit of code where you allocate
This is an archived mail posted to the Subversion Dev mailing list.