Re: vdelta changes

Karl Fogel <kfogel@collab.net> wrote:
> Branko, just to let you know -- had a few things on the stack today,
> so haven't had a chance to really dig into the binary diffing stuff
> you checked in. Today I only had a chance to read the code in a quick
> pass, and (of course, who could resist?) run a quick test of diffing
> two files. It worked perfectly.

Glad to hear it.

> The code is extremely readable. I think you should you strive for a
> little less clarity, otherwise some people might get the idea that
> this whole programming thing is really very easy.

Well, I can always (fill-region), if that'll make people maintain
a proper attitude of respect towards Us Software Engineers. :-))

> Monday first thing we'll be grokking the vdelta stuff in detail,
> because (among other things) we'll want to hook it into the
> adm_crawler.

O.K. Don't be too pedantic; there're a few typos I need to fix, and
most especially I'd like to get rid of svn_txdelta__window_size.
I put it in so that we could test with different window sizes, but I
want to make the delta generator reentrant. Maybe the window size
should be an attribute of svn_txdelta_stream_t.

    Brane
Received on Sat Oct 21 14:36:08 2006