Re: compiling a rainy day

On Fri, 8 Sep 2000, Greg Stein wrote:

(CC'ed to the neon guys since the patch below concerns their "territory")

> > * two prototype mistakes in subversion/include/svn_ra.h prevented my gcc to
> > compile.
>
> oops. my fault. I had these fixed already in my local version, but missed
> svn_ra.h when checking in the related .c file changes. Thanx for spotting
> this!

I figured it might be something like that. It wasn't that hard to catch!

> > * The previously discussed -pthread "problem"
>
> How'd that -pthread get in there?

Someone put it there! ;-)

% pwd
/home/dast/src/subversion/subversion/libsvn_wc/tests
% grep pthread Makefile.am
CFLAGS = -pthread

In fact, this effectively breaks compiling on solaris if I don't use
./configure --disable-shared. Now I only get that warning.

> Our "real" solution is to use apr/APRVARS to pick up necessary system
> libraries and compilation flags.
>
> > * No configure script seems to detect solaris' need for -lsocket
>
> Neon should have seen this, I think. Again, we would need to propagate this
> out to SVN to ensure that SVN linked with it (similar to APRVARS). I think
> neon/neon-config is the trick here.

It is just a matter of applying this to the neon aclocal.m4

*** aclocal.m4~ Fri Sep 8 11:48:58 2000
--- aclocal.m4 Fri Sep 8 13:20:22 2000
***************
*** 533,538 ****
--- 533,541 ----
        AC_CHECK_LIB(nsl,gethostbyname)
        )
  
+ dnl socket lib?
+ AC_CHECK_FUNC(connect, , AC_CHECK_LIB(socket, connect))
+
  NEON_SSL()
  
  ])

> > If this isn't just my fault, I'm willing to submit a fix for the last issue.
> > Patch for the first is included.
>
> Well, the right answer is getting the sub-packages to propagate their
> compile/link switches "up" to SVN during the configure process. If you
> can figure that out, then we'd really appreciate a patch.

In fact, libtool is our friend in there. If neon just takes care of its own
dependencies, libtool will make sure that we link with -lsocket when we link
with neon.

-- 
      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol