From: Greg Stein <gstein_at_lyra.org>
Date: 2000-09-02 10:24:43 CEST
On Fri, Sep 01, 2000 at 09:53:29PM -0500, Karl Fogel wrote:
apply_delta calls the XML parser to generate events against the walker
IOW, it is specific to the XML walker-event producer.
> - The only known purpose of svn_wc_get_change_walker() is to effect
Nope. It returns a walker that *any* change-producer can use.
The theory is that the client library calls get_change_walker and passes
> Therefore, my first instinct is that we don't both of these. :-)
Yup. apply_delta should go away. Producers will call into a walker
> What is it that get_change_walker() gets us that apply_delta()
apply_delta is an XML-based "pull" model for generating changes. It pulls
get_change_walker is for anybody that needs to "push" changes into a walker.
IMO, apply_delta goes and some other part of the library does something like
That code will occur whereever you happen to get the XML from.
At a minimum, keep apply_delta, but call it something like
-- Greg Stein, http://www.lyra.org/Received on Sat Oct 21 14:36:07 2006
This is an archived mail posted to the Subversion Dev mailing list.