sussman@tigris.org writes:
> MAJOR RENAME: svn_delta_parse() is now renamed svn_XML_parse() !
Request that we not use upper case in identifiers, even when it's an
acronym like xml? (I know, I've perpetrated them before too, and am
willing to do the necessary query-replace job).
The reason is simply that in the heat of coding, it's an annoyance to
hit the shift key. Also, visually, the sudden caps falsely imply that
something "important" is happening there, or that it might be a macro,
or something.
Thoughts?
-K
> * svn_delta.h: (svn_delta_parse): renamed to svn_XML_parse
> * delta_parse.c: (svn_delta_parse): renamed to svn_XML_parse
> * deltaparse-test.c: (main): call svn_XML_parse
>
> Revision Changes Path
> 1.70 +10 -10 subversion/subversion/include/svn_delta.h
>
> Index: svn_delta.h
> ===================================================================
> RCS file: /cvs/subversion/subversion/include/svn_delta.h,v
> retrieving revision 1.69
> retrieving revision 1.70
> diff -u -r1.69 -r1.70
> --- svn_delta.h 2000/08/31 22:16:16 1.69
> +++ svn_delta.h 2000/09/01 16:53:48 1.70
> @@ -363,7 +363,7 @@
> `replace_directory', which return batons for subdirectories,
> as explained below.
>
> - In the case of `svn_delta_parse', these would be the WALK_BATON
> + In the case of `svn_XML_parse', these would be the WALK_BATON
> and DIR_BATON arguments. Other producers will work differently.
>
> Most of the callbacks work in the obvious way:
> @@ -545,18 +545,18 @@
>
> } svn_delta_walk_t;
>
> -/* Create a delta parser that consumes data from SOURCE_FN and
> +/* Create a delta parser that consumes XML data from SOURCE_FN and
> SOURCE_BATON, and invokes the callback functions in WALKER as
> appropriate. WALK_BATON is a data passthrough for the entire
> - traversal. DIR_BATON is a data passthrough for the root
> - directory; the callbacks can establish new DIR_BATON values for
> + traversal. DIR_BATON is a data passthrough for the root directory;
> + the callbacks can establish new DIR_BATON values for
> subdirectories. Use POOL for allocations. */
> -extern svn_error_t *svn_delta_parse (svn_delta_read_fn_t *source_fn,
> - void *source_baton,
> - const svn_delta_walk_t *walker,
> - void *walk_baton,
> - void *dir_baton,
> - apr_pool_t *pool);
> +extern svn_error_t *svn_XML_parse (svn_delta_read_fn_t *source_fn,
> + void *source_baton,
> + const svn_delta_walk_t *walker,
> + void *walk_baton,
> + void *dir_baton,
> + apr_pool_t *pool);
>
>
> #endif /* SVN_DELTA_H */
>
>
>
> 1.72 +6 -6 subversion/subversion/libsvn_delta/delta_parse.c
>
> Index: delta_parse.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_delta/delta_parse.c,v
> retrieving revision 1.71
> retrieving revision 1.72
> diff -u -r1.71 -r1.72
> --- delta_parse.c 2000/09/01 03:36:11 1.71
> +++ delta_parse.c 2000/09/01 16:53:48 1.72
> @@ -1216,12 +1216,12 @@
> */
>
> svn_error_t *
> -svn_delta_parse (svn_delta_read_fn_t *source_fn,
> - void *source_baton,
> - const svn_delta_walk_t *walker,
> - void *walk_baton,
> - void *dir_baton,
> - apr_pool_t *pool)
> +svn_XML_parse (svn_delta_read_fn_t *source_fn,
> + void *source_baton,
> + const svn_delta_walk_t *walker,
> + void *walk_baton,
> + void *dir_baton,
> + apr_pool_t *pool)
> {
> char buf[BUFSIZ];
> apr_off_t len;
>
>
>
> 1.23 +5 -5 subversion/subversion/libsvn_delta/tests/deltaparse-test.c
>
> Index: deltaparse-test.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_delta/tests/deltaparse-test.c,v
> retrieving revision 1.22
> retrieving revision 1.23
> diff -u -r1.22 -r1.23
> --- deltaparse-test.c 2000/08/31 21:04:06 1.22
> +++ deltaparse-test.c 2000/09/01 16:53:49 1.23
> @@ -332,11 +332,11 @@
>
>
> /* Fire up the XML parser */
> - err = svn_delta_parse (my_read_func, source_baton, /* read from here */
> - &my_walker, /* call these callbacks */
> - my_walk_baton,
> - my_parent_baton, /* with these objects */
> - globalpool);
> + err = svn_XML_parse (my_read_func, source_baton, /* read from here */
> + &my_walker, /* call these callbacks */
> + my_walk_baton,
> + my_parent_baton, /* with these objects */
> + globalpool);
>
> apr_close (source_baton);
>
>
>
>
Received on Sat Oct 21 14:36:07 2006