Re: Text delta interface

Jim Blandy wrote:
>
> Dear folks working on text deltas ---
>
> I've committed an interface to subversion/include/svn_delta.h, under
> the heading "Text deltas", that describes the initial interface we
> would like to have to the text delta generator. If you could
> implement to that interface (and point out whatever problems you
> encounter), that would be great.

I had a look at the interface, and it looks fine as a starting point.

Reading the comments to svn_delta_op_t, I noticed the restriction that
a copy from the source to the target (the svn_delta_source op) can't
cross the source/target boundary. Neither the Vdelta algorithm nor the
vcdiff format have that restriction. Was this meant to make it easier
to stream the source and target data?

> We'll be adding to this interface over time, but I think everything
> needed to talk to a basic delta engine is there.

May I suggest a small change: s/ap_off_t/apr_off_t/g .

This brings me to another question I've been meaning to ask. Is it
safe to assume we'll be using the APR library throughout the code?
I noticed a copy of glib is in the repository, too. APR and glib
overlap in several places. Which is preferred?

    Brane

-- 
Branko Čibej                 <branko.cibej@hermes.si>
HERMES SoftLab, Litijska 51, 1000 Ljubljana, Slovenia
voice: (+386 1) 586 53 49     fax: (+386 1) 586 52 70