[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/svn_subr/parsetest Makefile parsetest.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-07-06 05:47:25 CEST

On Wed, Jul 05, 2000 at 09:35:00PM -0500, Ben Collins-Sussman wrote:
> Greg Stein <gstein@lyra.org> writes:
>
> > In the NOTE for ap_open(), it says, "*arg1 must point to a valid file_t
> > [sic], or NULL (in which case it will be allocated)"
> >
>
> Ah, you're right. Sorry. :)

Don't apologize... IMO, it is a silly "feature" of the API, and it is
obviously not blatantly specified enough, such that you and Joe both got
stung by the damn thing.

I'll go peruse the Apache code. There probably isn't a case where somebody
actually gives it an ap_file_t structure (the lifetime issues of that have
got to be scary). Presuming so, then we can change it. It is certainly *not*
typical of all the other APR functions.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:05 2006

This is an archived mail posted to the Subversion Dev mailing list.