Re: [MacPorts] #45496: Subversion with JavaHL crashes on Yosemite

> On Oct 27, 2014, at 6:22 AM, Philip Martin <philip.martin_at_wandisco.com> wrote:
> "Daniel J. Luke" <dluke_at_geeklair.net> writes:
> On Oct 24, 2014, at 3:09 PM, Daniel J. Luke <dluke_at_geeklair.net> wrote:
>>>> The JavaHL bindings
>>>> use the same libraries to access the code as the commmand line clients.
>>>> If one works and the other does not it implies that the different
>>>> libraries are getting loaded at runtime. I have no idea what you need
>>>> to do to get the correct libraries to load on OSX.
>>>
>>> make check-javahl sets DYLD_LIBRARY_PATH so the libraries from the build take precedence over any others. I'll check to see which library(s) are getting loaded at runtime both from the MacPorts build and my non-MacPorts build and see if there's anything there. Thanks for giving me some place to start...
>>
>> I don't see any difference between which libraries are getting loaded:
>
> All I can suggest is building with debug symbols and using a debugger.
> The code is in subversion/libbsvn_subr/sqlite.c and I would guess the
> problem is eithe SQLite initialisation in init_sqlite() or database open
> in internal_open().

The difference between my build that succeeded and the MacPorts build is that MacPorts sets MACOSX_DEPLOYMENT_TARGET (to 10.10 on yosemite). libtool's M4 macro before the just released 2.4.3 incorrectly call the linker with `-undefined suppress` instead of `-undefined dynamic_lookup` in this case.

I've added a small configure patch to MacPorts to work around this for now - I imagine if the next subversion release uses the current (or newer) libtool, then the patch won't be necessary anymore:

--- configure.orig 2014-10-29 10:20:21.000000000 -0400
+++ configure 2014-10-29 10:22:43.000000000 -0400
@@ -10348,7 +10348,7 @@
       case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
         10.0,*86*-darwin8*|10.0,*-darwin[91]*)
           _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[[012]][[,.]]*)
           _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
         10.*)
           _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;

--
Daniel J. Luke                                                                   
+========================================================+                        
| *---------------- dluke_at_geeklair.net ----------------* |                          
| *-------------- http://www.geeklair.net -------------* |                          
+========================================================+                        
|   Opinions expressed are mine and do not necessarily   |                          
|          reflect the opinions of my employer.          |                          
+========================================================+