[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Comments in svn:externals

From: BRM <bm_witness_at_yahoo.com>
Date: Tue, 13 Oct 2009 10:16:37 -0700 (PDT)

----- Original Message ----
From: Daniel Torreblanca <regulatethis_at_gmail.com>
>
On Tue, Oct 13, 2009 at 12:16 PM, Andy Levy <andy.levy_at_gmail.com> wrote:
>> On Tue, Oct 13, 2009 at 12:02, BRM <bm_witness_at_yahoo.com> wrote:
>>> Is there some way I can turn a line into a comment?
>>>
>>> I tried prepending a pound (#) but that didn't seem to work.
>>> I couldn't find anything in the SVN book, or a quick google search.
>>> If this is not supported, I think it would make a good feature to add.
>>
>> A comment doesn't seem like appropriate data to be storing with an
>> external definition. Why not enter it as part of the log message when
>> you commit the change to the property?
>
> And even beyond that, I don't see how this would be cleaner or more
> straightforward than simply making your external point to a specific
> revision, or better yet, point to a tag for the dependency. At least
> in that case a simple "svn info" within the external's directory would
> easily identify which version is being used. I pretty much always use
> tags/specific revisions for externals anyway since I don't want to
> deal with unexpected changes in my dependencies, but I'm sure there
> are many cases where that wouldn't work.

Not sure who you're talking to here...

If you follow my procedure in my original e-mail, you'll note that I tagged the dependency,
and am now trying to update a tagged copy of the project to work specifically
with that tagged dependency.

----- Original Message ----
From: Tyler Roscoe <tyler_at_cryptio.net>
>On Tue, Oct 13, 2009 at 12:16:38PM -0400, Andy Levy wrote:
>> On Tue, Oct 13, 2009 at 12:02, BRM <bm_witness_at_yahoo.com> wrote:
>> > Is there some way I can turn a line into a comment?
>>
>> A comment doesn't seem like appropriate data to be storing with an
>> external definition. Why not enter it as part of the log message when
>> you commit the change to the property?
>
> I disagree. Surely the easiest place to insure that a special note about
> an external is visible to developers ("MUST be updated when we branch")
> is to put it right there in the property.
>
> svn logs are not a replacement for inline comments mostly because
> they're not inline.

Agreed.

Also, I like having them there as comments as it makes it easier to revert to the original if needed -
just switch the commented lines. This also is useful when you branch for a feature, or
for integrating a new version of the dependency - you still know exactly which version
it was previously using and can quickly revert to it if need be, without having to do a ton
of searching or guess-work. (You may also be skipping numerous versions of the
dependency - e.g. updating from 2.0 to 2.5, skipping 2.1, 2.2, 2.3, 2.3.1, 2.4, and 2.4.[1-9]).

Logs are great, but they don't resolve everything.

Ben

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2407228

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-10-13 22:57:55 CEST

This is an archived mail posted to the Subversion Users mailing list.