[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Candidate bug: svnadmin should refuse to create nested repositories

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 22 Aug 2008 09:57:08 -0700

> -------Original Message-------
> From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
> Subject: Re: Candidate bug: svnadmin should refuse to create nested repositories
> Sent: 22 Aug '08 09:38
>
> Hyrum K. Wright wrote on Fri, 22 Aug 2008 at 09:09 -0700:
> > >  -------Original Message-------
> > >  From: Quinn Taylor <quinntaylor_at_mac.com>
> > >  Subject: Re: Candidate bug: svnadmin should refuse to create nested repositories
> > >  Sent: 22 Aug '08 08:52
> > >  
> > >  >> It is definitely a no-no to create a repository within a  
> > >  >> repository... so it wouldn't hurt if svnadmin would detect and warn  
> > >  >> about, or event prevent, this situation.
> > >  >
> > >  > Agreed.  This can lead to a sticky situation.  The one question,  
> > >  > though, is how far up the directory structure should svnadmin  
> > >  > recurse to determine if the proposed new repository is in an  
> > >  > existing repository?  1 level?  2 levels?  All the way to the root?
> > >  >
> > >  > -Hyrum
> > >  
> > >  Unless the user is creating deeply-nested directories within the  
> > >  repository and creates a "sub-repository" therein, it shouldn't be  
> > >  necessary to traverse up too many levels. OTOH, creating repositories  
> > >  is a relatively infrequent event, and traversing up to the root  
> > >  wouldn't incur a heavy penalty.
> >
>
> Well, "svnadmin create $PATH" could just do whatever svn_ra_local__open()
> does to figure out whether $PATH is contained in some repository... which
> boils down to calling svn_repos_find_root_path() in the right place,
> right?

Heh, I'd forgotten all about that case. That should make things pretty easy.

-Hyrum

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-08-22 18:57:36 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.