[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Modifying log message in pre-commit hook

From: Andy Levy <andy.levy_at_gmail.com>
Date: Thu, 20 Mar 2008 11:33:00 -0400

On Thu, Mar 20, 2008 at 11:30 AM, <kmradke_at_rockwellcollins.com> wrote:
> Karl Fogel <kfogel_at_red-bean.com> wrote on 03/20/2008 12:35:43 AM:
>
> > kmradke_at_rockwellcollins.com writes:
> > > I would like to expand an user entered BUGID in the log message in the
> > > pre-commit hook (I.E. add missing zeros at the beginning of the
> > > number). I have the new value and the old log message, I just
> > > do not know how to apply the changes to the transaction in the hook.
> > >
> > > svnadmin setlog does not take a transaction argument. Should it?
> > >
> > > svn propset/propedit do not take transaction arguments. (I'm ok with
> this
> > > since I would rather use the specific svnadmin setlog.)
> > >
> > > The pre-commit.tmpl file seems to indicate changing revision
> properties
> > > such as svn:log is ok, but there doesn't seem to be an easy way to do
> it
> > > without using either the perl or python API directly.
> > >
> > > It is possible to rewrite the log message in the post-commit hook, but
> > > doing it there would significantly complicate other hooks for non-SVN
> > > related reasons.
> > >
> > > Thoughts?
> >
> > Yes, you could do it in the post-commit hook...
>
> Yep. That unfortunately complicates matters because the pre-commit
> hook needs to duplicate the log message in other systems.

What if the commit fails? Should that log message still be put into
those other systems?

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-03-20 16:33:27 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.