Re: svnlook log doesn't return message

On Feb 29, 2008, at 03:48, Ryan Schmidt wrote:

> And of course right after I sent my reply, I thought a bit more
> about the problem and realized that because you're using the return
> value from exec(), which is just the last line of output, you're
> only checking the last line of the log message. If you have a nice
> long log message but it ends with a blank line (for example if it
> was composed in an editor like mine which always makes sure that
> every saved file ends with a blank line), your script will think
> you entered no log message, and will issue an error. You should be
> checking the entire output of svnlook log, not just the last line.

And for the same reason, your php lint checker is only checking the
last file in the list.

And for the same reason, your not-allowed-filename checker is only
checking the last file in the list. Also, from the comments it sounds
like you want to check only files that are being added, which makes
sense. But your code only checks a file *unless* it's being added. To
fix this, this line:

if (!preg_match_all("/[A]\s+([^\s]+)$/i", $cmd, $matches)) {

should be changed to

if (preg_match_all("/[A]\s+([^\s]+)$/i", $cmd, $matches)) {

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-02-29 11:27:52 CET