"commit after review" strategy?

Hello.

In my team we are using SVN and I am interested in deploying a use
strategy in which only commits are allowed if reviewed by a second
developer.

Thus, the ideal use case for this strategy would be:

- developerX uses the commit command for checking in a change
- SVN replies "pre-commit successful, pending revision" or something
like that, and the patch is sent to developerY or held in a repository
of proposed patches.
- developerY receives patch (or marks the patch as reviewed on the
proposed patches repository) and approves it: it gets committed as the
user developerX+developerY if the patch could be applied well, or the
patch gets refused and developerX receives the reason: either the patch
could not be applied, or the patch was not correct (and the remarks of
developerY).

Is anybody working with a similar strategy here? If yes, how have you
deployed it?

If not, how could you deploy/develop it?

I know that a similar strategy can be done, with a less automatic way,
via a ticket system (posting patches to tickets and getting
approval/refusal on the ticket), but I am interested in a more automatic
way where the developer wouldn't need to worry on generating diffs,
applying patches when approved (and by the advantage of having users
with the form "userA+userB" in order to improve blaming logs).

Regards,

        Andrés [ knocte ]

-- 
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org