Re: hook-script: commit-email.pl

Gustavo Delfino wrote:
> Then I propose this change in commit-email.pl:
>
> ***************
> *** 546,554 ****
> }
>
> my @head;
> my $formatted_date;
> ! if (defined $stdout)
> {
> $formatted_date = strftime('%a %b %e %X %Y', localtime());
> push(@head, "From $mail_from $formatted_date\n");
> }
> --- 546,554 ----
> }
>
> my @head;
> my $formatted_date;
> ! if (defined $stdout && $stdout == 1)
> {
> $formatted_date = strftime('%a %b %e %X %Y', localtime());
> push(@head, "From $mail_from $formatted_date\n");
> }
>
> Agree? Otherwise my notifications are being send screwed up with double
> From headers.

Yes, that is both a correct analysis of the problem and a working
solution. I don't have commit access to that part of the repository, so
please read through:

     http://subversion.tigris.org/hacking.html#patches
and http://subversion.tigris.org/hacking.html#log-messages

and submit a patch to dev@subversion.tigris.org (you don't need to be
subscribed to post) with a log entry as described above. Please make
sure to provide a unified diff (diff -u) as that is much easier to read
in general (though for a single line change it doesn't make much
difference).

I'm already committed to rewriting commit-email.pl (but I haven't been
able to gain much traction recently), but it would be good to get this
patch into the trunk in case 1.5 comes out before I get it rewritten.

Thanks for researching this and providing the patch...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org