[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Adding Revision Number to Changes file comment

From: Andy Levy <andy.levy_at_gmail.com>
Date: 2007-02-08 18:15:36 CET

On 2/8/07, Andrew Close <aclose@gmail.com> wrote:
> On 2/8/07, Jeff Smith <jsmith@robotronics.com> wrote:
> > On Wednesday 07 February 2007 17:00, Ryan Schmidt wrote:
> > > Do NOT modify any file in a pre-commit hook. The server has no way
> > > of informing the client that such a modification has taken place,
> > > and then the server's idea of what the revision looks like is
> > > different from the client's, which will lead to badness. So do not
> > > do this.
>
> hi
>
> i'm jumping in in the middle of this thread, just joined the group,
> and this thread topic caught my eye.
> we're implementing SVN and were considering using the pre-commit hook
> to do code formatting (beautification/style standards). if this isn't
> the place to do it, is there a better way aside from having to beat on
> ppl that don't follow style guideline?

Usually the recommendation is to run your beautification/style
standards rules against the files being committed (in the pre-commit
hook), reject the commit if the test fails, and inform the would-be
committer why they were rejected. This puts the onus on the developer
to make sure his/her code is clean before committing.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Feb 8 18:16:15 2007

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.