[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Changing files being committed

From: Janulewicz, Matthew <MJanulewicz_at_westernasset.com>
Date: 2005-10-03 18:37:37 CEST

There was a long discussion about this on the list a few months ago, re:
code formatting tools. Although overall it comes down to admin
preference, as an SCM practitioner, it behooves you to not change
people's code as it is checked in. If the tool has a glitch, it may
break your code. Plus, if the programmer checks his code back out in a
week he might not recognize it, which is not a good thing. Not to
mention the fact (alluded to by someone else) that when a programmer
checks in his code and thinks he has the current revision, he really
doesn't. This is a Bad Thing(tm).

Coding standards and such are put in place for people to follow and in a
large shop (or any sized shop, really), allowing everyone to write code
in whatever way they want, then changing it without their knowledge,
will eventually create a big mess. The preferred method is to publish
your coding standards, encourage use of the tool, and reject code that
does not comply. Teach them to fish, don't steal their fish while they
aren't looking.

-Matt

-----Original Message-----
From: Paul Koning [mailto:pkoning@equallogic.com]
Sent: Monday, October 03, 2005 7:09 AM
To: stein@duvel.ir.iit.edu
Cc: scott.palmer@2connected.org; users@subversion.tigris.org
Subject: Re: Changing files being committed

>>>>> "stein" == stein <S3> writes:

 stein> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

 stein> So there is nothing in between start_commit and pre_commit
 stein> where it knows which files it will be looking at but hasn't
 stein> diff'd them yet? There should be an option to handle the
 stein> individual files.

I disagree. If I check something in, I want the repository to end up
looking like what's in my sandbox. If that's not acceptable, the
hooks can reject my checkin.

      paul

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

**********************************************************************
E-mail sent through the Internet is not secure. Western Asset therefore recommends that you do not send any confidential or sensitive information to us via electronic mail, including social security numbers, account numbers, or personal identification numbers. Delivery, and or timely delivery of Internet mail is not guaranteed. Western Asset therefore recommends that you do not send time sensitive or action-oriented messages to us via electronic mail.
**********************************************************************

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon Oct 3 18:40:41 2005

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.