[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Post Commit Code Formatting

From: Durfee, Bernard <Bernard.Durfee_at_suny.edu>
Date: 2005-06-23 16:07:11 CEST

> Second, while I understand the reasons given, I'm not sure I
> agree. Is it Subversion's job to prevent anyone from
> engaging in activities which are forbidden in select
> industries? Has the Subversion team, at some point, decided
> that it would be wrong to provide a means to engage in
> activities which the industry at large does not acknowledge
> as "best practice"?
>
> It seems to me that the Subversion developers have decided to
> lock a door for reasons which are primarily non-technical,
> and it seems to me that those whose industries do not
> prohibit automatic code alteration should be allowed to use
> that door if they choose to do so.

Exactly. Although I am starting to see how this could truly be a
complicated technical proposal, but the discussion(s) on the subject
always seem to be tainted by philosophical rancor.

> I am under the impression that a pre-commit hook is not
> currently permitted to modify the data being committed. This
> is the locked door to which I am referring, and unlocking
> this door would solve Bernard's issue. Nobody is forcing
> anyone else to walk through the unlocked door.
>
> So, I now ask of the Subversion developers: are there
> *technical* reasons which would inhibit permitting a
> pre-commit hook to modify the data being committed?

Right, that is the proper question that needs to be explored.

> Having said all that, put your code formatter in your build
> script (or in your IDE), so that it occurs right before
> compilation. Your developers will be forced to reckon with
> any errors caused by the formatter before they can even test
> their code locally. I assume that you test before you commit....

This is the route that I am starting to explore. The problem is that
there are various clients in use, especially in open-source projects
where this 'feature' would be most useful.

Bernie

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Jun 23 16:10:43 2005

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.