Re: experimental svn-win32-1.1-dev-9226: memory leak closed

Ben Collins-Sussman <sussman@collab.net> writes:

> On Wed, 2004-04-07 at 10:39, Ben Collins-Sussman wrote:
>> On Wed, 2004-04-07 at 10:31, Jan Hendrik wrote:
>>
>> > Second attempt, now with experimental build (thanks, Ben) svn-
>> > win32-1.1-dev-9226.zip and commit succeeded, using a maximum
>> > of 14 MB of memory!
>>
>> Hm, I don't think r9032 (which I presume is the fix on /trunk which has
>> solved the problem) has been backported to the 1.0.x branch. Perhaps it
>> should be a 1.0.2 candidate? It looks like it could seriously affect
>> tortoisesvn users...
>
> Hm, now I wonder. r9032 specifically fixed a runaway memory bug
> whenever 'svn up' tried to delete many things. But Jan's memory bug was
> about commits. So it must be some *other* memory-fix to /trunk that's
> at work here. Anyone know which one that is? That's the one we should
> backport.

How about this one?

------------------------------------------------------------------------
r8949 | julianfoad | 2004-03-09 15:43:49 +0000 (Tue, 09 Mar 2004) | 7 lines

Reduce memory usage of multiple-target commits (part of issue 1635).

Patch by D.J. Heap <dj@shadyvale.net>.

* subversion/libsvn_client/commit.c
  (svn_client_commit): Use a subpool in the target-processing loop.

------------------------------------------------------------------------

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org