[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Double click on property change from changed file window doesn't work anymore

From: David Balažic <david.balazic_at_comtrade.com>
Date: Tue, 3 Mar 2015 19:21:09 +0100

Hi!

Not sure if this is the same, but:
With TSVN v1.8.10 (64bit) in the "Changed files" window, double-click on a folder item does nothing and also right click / "Compare revisions" does nothing.
At least for the second thing either one of this would be expected:
 - a message apears explaining why nothing happened (or something happened, that I am not aware of)
 - the menu item with no meaning would be disabled
 - the menu item with no meaning would not be shown at all

Regards,
David Balažic
Software Engineer
www.comtrade.com

> -----Original Message-----
> From: Thijs de Ridder [mailto:thijs.de.ridder_at_mep-telecom.com]
> Sent: 20. August 2014 10:25
> To: users_at_tortoisesvn.tigris.org
> Subject: RE: Double click on property change from changed file window
> doesn't work anymore
> Importance: Low
>
> On 19.08.2014 21:00, Stefan Küng wrote:
> >
> > On 19.08.2014 18:09, Ben Fritz wrote:
> > >
> > > On Mon, Aug 18, 2014 at 2:35 PM, Stefan Küng <tortoisesvn_at_gmail.com
> > > <mailto:tortoisesvn_at_gmail.com>> wrote:
> > >
> > > > The same issue happens to svn:external changes.
> > > > When I right click on the folder and click on 'Compare revisions'
> > > > TortoiseMerge with the diff of svn:mergeinfo is shown.
> > > >
> > > > When I try the same steps with TortoiseSVN 1.7.13, Build 24257 -
> > > 64 Bit,
> > > > it works as I expected.
> > > >
> > > > Is this changed by design, or is this a bug?
> > >
> > > This change is by design because most users are not interested in
> > > property diffs.
> > > You still get the property diffs with the context menu.
> > >
> > >
> > > I agree, but only for files. I disagree, for directories. On a
> > > directory, the ONLY interesting change on a double-click, is the
> > > properties. Right now, a double click on a directory from the "compare
> > > revisions" or "check for modifications" or the log always does NOTHING
> > > AT ALL which is useless.
> > >
> > > Is it too difficult to treat files and directories differently here? I
> > > think the best case would be to show property differences when double
> > > clicking a directory in the "Changed files" dialog, because there is
> > > nothing else to show. Files can continue showing only the file diff.
> > >
> > > A more general solution I'd also support, is any "properties only"
> > > change would show the property diff on a double-click.
> > >
> > > The current behavior, doing nothing at all, is not useful in any
> > > scenario I can think of, and only causes confusion why the dialog is not
> > > responding to my input.
> >
> > Done in r25780.
>
> I tested this with the nightly build and it works fine for me now.
> Thanks for the quick fix Stefan!
>
> Best regards,
>
> Thijs
>
> ------------------------------------------------------
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMess
> ageId=3086947
>
> To unsubscribe from this discussion, e-mail: [users-
> unsubscribe_at_tortoisesvn.tigris.org].

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3102593

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2015-03-03 19:21:21 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.