[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Create patch trivial issue

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: Tue, 23 Feb 2010 09:24:30 +0000

On 22 February 2010 18:41, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> On 22.02.2010 17:51, (:Dedalus) wrote:
>> When I create a patch, after I fill the name of file and save it as
>> patchfile (*.patch), TortoiseSvn save it without extension as happeans
>> when I save as all files (*.*).
>>
>> Using TortoiseSvn 1.6.7 on Windows 7
>
> That's by design: some people don't want an extension for patch files or
> a custom one (e.g., *.txt).

The save dialog seems a bit confused here. For a program like M$ Word
you can choose the type to save as from the drop-down list (yes, I
know this is a little different as it affects the saved format too).
That extension is always added to the name you type, unless the name
entered already heas exactly that extension. The drop down list has
exactly one extension per entry. Having "*.patch; *.diff " as a
save-as type makes no sense because it cannot add both and it has no
way to choose which one of the two. That makes sense only in the
File-open dialog.

The simplest solution would be to drop the *.patch; *.diff altogether
and keep the existing *.* behaviour.

A nicer solution, but which needs more work would be to have separate
*.patch *.diff *.txt and *.* entries. For all but *.* the extension
would be added if the same extension is not there already. And it
would remember the last type used so the same type comes up next time.

Simon

-- 
:       ___
:  oo  // \\      "De Chelonian Mobile"
: (_,\/ \_/ \     TortoiseSVN
:   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
:   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2450914
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-02-23 10:24:36 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.