Re: Got "no error occurred"

Konstantin Kolinko wrote:
> Hi,
>
> Some googling shows that the "No error occured" message can be
> produced by the GetLastError() Windows API call.

The "no error occurred" or "the operation finished successfully" 'error'
dialogs usually happen because an API check is done wrong: some API's
return 0 when they fail, some return a value != 0 when they fail.
Checking that wrong and then showing the error obtained with
GetLastError() causes these. But the cause is not GetLastError().

(just want to be exact here, not to correct your analysis)

> It is just a wild guess, where it might occur:
> clicking on a menu item results in TortoiseProc.exe being launched
> with relevant /command arguments.
>
> If the launch (i.e. CreateProcess call in ContextMenu.cpp) fails,
> a message box is shown with title "Error" and with a message
> provided by GetLastError() call.

Well, that could be. But the docs for CreateProcess() indicate that when
an error occurs, GetLastError() would provide it.

> It is hard to imagine why CreateProcess can fail without providing an
> error code. Maybe some malware is intercepting the call?

Malware? Oh, you mean those virus scanners and firewalls people pay big
bucks for?
I still have to find one virus which causes me more problems than all
the virus scanners I had to use in my office.

> Also, I would suggest to change the title of that message box
> to something more specific, like "TortoiseProc launch failed".

Good idea. Will do.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net