[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug: Secretly committing files behind the scene

From: Jean-Marc van Leerdam <j.m.van.leerdam_at_gmail.com>
Date: Thu, 12 Jun 2008 10:26:08 +0200

Hi Peter,

On 12/06/2008, Peter Olsen <cubetimer_at_hotmail.com> wrote:
>
> Found a bug when editing files while committing other files. TortoiseSVN
> will commit everything - even files that are not shown in the "TortoiseSVN
> Commit Window".
>
> Platform:
> TortoiseSVN version 1.4.8
> WinXP
>
> Repro:
>
> 1. Edit a few files in a project.
> 2. Right click the project folder at choose "SVN Commit...".
>
> TortoiseSVN will show you a list of files you've edited - all checked.
>
> 3. Without closing the "TortoiseSVN Commit Window" edit another file in your
> project (one that you didn't edit in step 1).
> 4. Go back to the "TortoiseSVN Commit Window" and commit your files.
> 5. Check the log.
>
> Notice that the file you edited in step 3 has been committed even though it
> wasn't listed in the "TortoiseSVN Commit Window". In fact you can press F5
> to refresh between step 3 and 4 and it will in fact show you the extra file.
>
> The behavior I would expect would be that TortoiseSVN would only commit
> files that are found and shown in step 2. Don't rescan and specially don't
> rescan behind the scene.
>

It's not really a bug because in fact TSVN does not re-scan the
folders: if all files are selected the commit is a recursive commit
(TSVN passes the top folder to the SVN libraries for committing).
If you deselect at least one versioned file, then TSVN will do a
non-recursive commit by supplying all checked files individually to
the SVN libraries. In that case, any files modified after the dialog
was opened will not be committed.

Maybe we need some kind of hint to indicate to the user that the
commit will be recursive or not. I don't know what form that hint
should take though.

-- 
Regards,
Jean-Marc
----------------
    ___
   // \\  @@     "De Chelonian Mobile"
  / \_/ \/._)    TortoiseSVN
 <\_/_\_/ /      The coolest Interface to (Sub)Version Control
  /_/   \_\      Check out http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org
Received on 2008-06-12 10:26:28 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.