Re: Fix for Danish translation, but which?

On 01/08/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Simon Large wrote:
> > On 31/07/07, Jan Normann Nielsen <lists@dubbekarl.dk> wrote:
> >> Simon Large skrev:
> >>> On 30/07/07, Jan Normann Nielsen <lists@dubbekarl.dk> wrote:
> >>>
> >>>> Now I've tried using "msgfmt --check" on my old, defective Danish
> >>>> translation and it reports three errors of which I've fixed the two. The
> >>>> third one is:
> >>>>
> >>>> Tortoise_da.po:5682: number of format specifications in `msgid' and
> >>>> `msgstr' does not match
> >>>> found 1 fatal errors
> >>>>
> >>>> My Tortoise_da.po around line 5682 contains:
> >>>>
> >>>> #: ID:17,
> >>>> #, c-format
> >>>> msgid "webviewer:pathrevision\nURL pointing to the web viewer for the
> >>>> repository for a specific file and revision.\nThe string %REVISION% in
> >>>> the URL is replaced with the revision number,\nthe string %PATH% is
> >>>> replaced with the path to the file relative to the repository root."
> >>>> msgstr "webviewer:pathrevision\nURL, der peger pċ en web-visning af en
> >>>> bestemt fil og revision i versionsarkivet.\nStrengen %REVISION% i denne
> >>>> URL bliver erstattet med revisionsnummeret,\nog strengen %PATH% bliver
> >>>> erstattet af den relative sti til filen i forhold til versionsarkivets rod."
> >>>>
> >>>> I don't understand why this error occurs. Can anyone help?
> >>>>
> >>> Is that c-format supposed to be there?
> >>>
> >>> Simon
> >>>
> >> It is already in Tortoise.pot, for both the pieces of text relating to
> >> "webviewer:" properties.
> >
> > I think %PATH% and %REVISION% should be in quotes in the original
> > text, the same way that %BUGID% is. I guess the quoted version works
> > because it stops msgfmt thinking this is a printf marker?
> >
> > This is also in TortoiseShell/resource.rc. Maybe someone else can do
> > that as I can't rebuild Tortoise.pot
>
> I think we should wait for Lübbe to return from his vacation. I've
> checked the *_de.po file, and it's not in quotes there either. And as
> far as I can see, that file doesn't do anything special.
> So, assuming that Lübbe does everything right, we shouldn't change
> anything until he can explain what he does exactly.

It wouldn't be in quotes in the *_de.po file because it's not in
quotes in Tortoise.pot, because it's not in quotes in
TortoiseShell/resources.rc

We do use quotes around %BUGID% in the same .rc file. But I agree it
would be better to wait for Lübbe to find the real source of the
problem.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org