Quoth Tobias Schäfer:
> The changes:
> - change all calls to tortoiseproc to contain "/tempfile" as a parameter
> - Change the logic so that the path argument is deleted if /tempfile is
> passed and not if /nottempfile is not passed as a parameter
>
> Does this sound sensible? If so, I'll file an issue and implement it if no
> one is faster in starting the implementation.
Instead of doing that, I'd make it /tempfile="whatever path" (similar to
what I suggested in the original post). That completely divorces the
tempfile from the /path option, so then there should be absolutely no
danger of confusion.
If the tempfile always contains just a list of files to act on, then I'd
go one step further and call it /filelist or something. Then it could
be documented as such and used when other programs want to pass in
pregenerated lists of files. (If it's some command-specific weird
internal format, then it's probably best staying fairly obscure.)
Finally, on the whole temp-file-cleanup thing: does the shell extension
fire-and-forget the call to TortoiseProc, or does it wait around (in a
separate thread, maybe?) for it to finish? If it has to wait anyway
then the shell extension could be responsible for cleaning up the temp
file afterwards. It's always better if the creator of a temp file is
the one who cleans it up.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Mon Sep 25 02:45:12 2006