[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: /notempfile

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-09-23 20:10:43 CEST

On Friday 22 September 2006 18:52, Stefan Küng wrote:
> 1. TSVN was never designed to be automated, this was added much later.
> 2. Passing a list of selected files in a temp file is necessary to avoid
> too long command lines (which is limited to 4096 chars on win2k). And
> since it's bad to leave temp files lying around, TSVN removes those temp
> files after use. That's why the file specified in the param is removed:
> TSVN assumes it's a temp file containing the list of files. And no, we
> can't just define that the calling program should remove the temp file,
> because in TSVN's case, the calling program is the shell extension,
> which isn't 'running' and can't wait for TortoiseProc to finish (or the
> whole explorer would be blocked until TortoiseProc is finished).

I also dislike the current behavior and would like to change it. It's kind
of dangerous.

The changes:
- change all calls to tortoiseproc to contain "/tempfile" as a parameter
- Change the logic so that the path argument is deleted if /tempfile is
passed and not if /nottempfile is not passed as a parameter

Does this sound sensible? If so, I'll file an issue and implement it if no
one is faster in starting the implementation.

Everyone currently calling tortoiseproc with /notempfile will still have the
same behavior when installing a release with the above changes.
Everyone currently calling tortoiseproc without /notempfile will have to
add /tempfile when installing a release with the above changes.

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Sat Sep 23 21:06:33 2006

This is an archived mail posted to the TortoiseSVN Users mailing list.