[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Feature request: Warning for Logrex-Issues

From: Jan Linnenkohl <jan.linnenkohl_at_gmx.de>
Date: 2006-06-07 20:27:00 CEST

Hi Stefan,

I think the same thing will appear in the CopyDialog:

Index: CopyDlg.cpp
===================================================================
--- CopyDlg.cpp (revision 6732)
+++ CopyDlg.cpp (working copy)
@@ -159,6 +159,7 @@
                 CBalloon::ShowBalloon(this,
CBalloon::GetCtrlCentre(this,IDC_BUGID), IDS_LOGPROMPT_ONLYNUMBERS, TRUE,
IDI_EXCLAMATION);
                 return;
         }
+ m_sLogMessage = m_cLogMessage.GetText();
         if ((m_ProjectProperties.bWarnIfNoIssue) && (id.IsEmpty() &&
!m_ProjectProperties.HasBugID(m_sLogMessage)))
         {
                 if (CMessageBox::Show(this->m_hWnd,
IDS_LOGPROMPT_NOISSUEWARNING, IDS_APPNAME, MB_YESNO |
MB_ICONWARNING)!=IDYES)
@@ -190,7 +191,6 @@
         }
         m_URLCombo.SaveHistory();
         m_URL = m_URLCombo.GetString();
- m_sLogMessage = m_cLogMessage.GetText();
         m_HistoryDlg.AddString(m_sLogMessage);
         m_HistoryDlg.SaveHistory();
 

Thanks Jan

 

Jan Linnenkohl wrote:
> Stefan wrote:
>
> >I already get the warning if I set bugtrag:warnifnoissue and
> >bugtraq:logregex (and no issue is entered in the log message). But I'm
> >using the latest version from trunk...
>
> Hi Stefan,
> I tested today also with the latest version and there is still the
problem.
> May be I didn't describe the problem in the right way. The warning windows
> pops always up, independent if I enter a correct issue number (with
> Logregex) or not.

Fixed in revision 6732.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org

Received on Wed Jun 7 20:40:09 2006

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.