[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit

From: Jens Wilhelm <willorix-tsvndev_at_yahoo.de>
Date: Thu, 8 Sep 2016 08:31:02 -0700 (PDT)

In other words:
/trunk/src/TortoiseProc/CommitDlg.cpp Rev. 27110 Line 537

I would replace:
  bool doIt = (taskdlg.DoModal(GetSafeHwnd()) == 1);
by:
  bool doIt = (taskdlg.DoModal(GetSafeHwnd()) != 2);

because doIt stands for abort.
Commit should only proceed if the user inputs "proceed ...". Cancelling taskdlg shoud not lead into commit.

Best regards

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3185168

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2016-09-12 17:20:01 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.