Refactoring CLogDlg::ShowContextMenuForChangedPaths() by doing extract method

Hi,

I am proposing to change the CLogDlg::ShowContextMenuForChangedPaths() method to make it shorter and have each menu-handling case: statement call one function. The refactoring shortens the 650+ line function significantly, reduces cyclomatic complexity, promotes re-use and makes things easier to understand in my opinion. Downside is that you now have to navigate to each "Execute..." method to see the code. Attached, please find a proposed patch. Functionally nothing should be changed, even though some break statements are now return statements.

If I don't hear anything negative about this in the next little while, I will commit.

Best,
Friedrich Brunzema

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3056564

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].