[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

get rid of CStdioFileT::ReadString(CStringA& rString)

From: <abel_at_abel.hu>
Date: Tue, 17 Apr 2012 12:01:13 +0200

Hello,

I suggest to remove completely CStdioFileT::ReadString(CStringA& rString).

- It's nowhere used with a CStringA typed parameter.
- I see that the purpose is to be able to use the class regardless of
whether compiling to Unicode or not. Problems:
- - In case of a Unicode build the CStringA version is never ever used.
- - In case of non-Unicode compiling the compiler would throw an error
because two functions would exist with the same signature (because
CString is defined to CStringA then).
- - Actually compiling to non-Unicode is not even possible:

8>------ Rebuild All started: Project: TortoiseProc, Configuration:
Debug Win32 ------
8> stdafx.cpp
8>c:\program files (x86)\microsoft visual studio
10.0\vc\atlmfc\include\afxtaskdialog.h(14): fatal error C1189: #error
: CTaskDialog requires _UNICODE to be defined.

I attach the patch file to remove this unnecessary function (once
again: it isn't used, and it would cause a compile error if other
compile errors would be fixed).

Have a nice day,
Ábel

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

Received on 2012-04-17 12:04:40 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.