[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

new link-style buttons in commit dialog register on non-captured mouseup

From: z <zeromus_at_zeromus.org>
Date: Thu, 8 Mar 2012 17:48:21 -0800 (PST)

testing in tsvn 1.7.6 build 22632 32bit on windows 2003.

Start making a commit. use the recent messages button. Position the recent messages dialog so that an entry is directly over one of the link-style buttons (one of all, none, non-versioned, versioned, etc.) I recommend positioning it over non-versioned to experience the full madness. Now, doubleclick a recent message. Your mouse button will still be held down while this dialog is dismissed. Now release the mouse button. Since your mouse is over "non-versioned", at the moment of release, this button will be activated. All your non-versioned files will get checked.

This information is not just about the bug, but why it is severe: This is especially problematic if you have 100000s of non-versioned files, since you will not know that theyre being selected, and youll go to click OK to commit, and things will mysterious run slow and then suddenly all your junk will be added (since theyre all put into the add status when you click OK.. which I do not necessarily argue with) and your commit will now be a mess.

Suggested resolution is to fix the link-style buttons to act like normal buttons, or normal browser links (I dont know what the standard is for dialogbox link buttons, since theyre unusual)

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2933354

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-03-09 06:52:39 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.