Doc potfile build failing

Hi folks,

I have just been trying the recent speedups for the docs build and it
now fails for me when building the pot file.

The problem seem to be with 2 recent changes to xml2po.py

r15550 works OK
in r22174 I get these errors:
     [echo] Checking if 'source/TortoiseSVN_en.xml' is up to date
     [echo] Up to date
     [echo] Creating po template from sources
     [exec] entities replaced ( 0 , 12000 )
     [exec] Traceback (most recent call last):
     [exec] File "xml2po.py", line 747, in <module>
     [exec] setTranslations()
     [exec] File "xml2po.py", line 221, in setTranslations
     [exec] file = open(mofile, "rb")
     [exec] IOError: [Errno 22] invalid mode ('rb') or filename: ''

BUILD FAILED - 0 non-fatal error(s), 7 warning(s)

I'm guessing it was tested only in translation mode and not potfile
mode. potfile1.patch addresses this, but I'm not sure the test is
optimal.

r22183 causes a different breakage:
     [exec] File "xml2po.py", line 623
     [exec] if (with_help):
     [exec] ^
     [exec] IndentationError: unindent does not match any outer
indentation level

BUILD FAILED - 0 non-fatal error(s), 4 warning(s)

My guess here is that the tab characters are actually needed in this
case to enable the indent detection to work.
potfile2.patch puts the tabs back into those 2 lines only. Again I
don't know if this is right as I know next to nothing about python.

If someone who knows more about the build process and about python
could check these I would be grateful.

Simon

-- 
:       ___
:  oo  // \\      "De Chelonian Mobile"
: (_,\/ \_/ \     TortoiseSVN
:   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
:   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2865490
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].