[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - suspicious casts, suboptimal code

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 02 Sep 2011 20:25:05 +0200

On 02.09.2011 09:29, Dmitry wrote:
> Hey.
>
> Attached are two untested patches.
>
> One addresses suspicious casts - casts where a pointer size type is
> casted to a 32-bit integer and then is implicitly converted back to a
> pointer size type. Such casts make code highly non-portable to 64
> bit. I'm not sure whether all of them are that bad, but most are.
>
> Another one addresses minor issues like code duplication, repeating
> checks, hardcoded constants, unneeded deep copying.

Committed in r21927 and r21928.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2834678
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-09-02 20:26:08 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.