Patch - suspicious casts, suboptimal code

Hey.

Attached are two untested patches.

One addresses suspicious casts - casts where a pointer size type is casted to a 32-bit integer and then is implicitly converted back to a pointer size type. Such casts make code highly non-portable to 64 bit. I'm not sure whether all of them are that bad, but most are.

Another one addresses minor issues like code duplication, repeating checks, hardcoded constants, unneeded deep copying.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2834517

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].