Re: Patch - code duplication and unneeded actions

On 2011-06-30 10:47, Dmitry wrote:
> Hey.
>
> Attached is an untested patch that addresses the following problem is TMerge: when detecting whether to enable a button code loops though views. Even if it already decided to enable the button it proceeds to other views which looks redundant and only wastes time. Also code doing that is heavily duplicated.
As Stefan commit it already just side note:

I had not time to analyse problem deeply so I left it as it is even I
have seen that.
I guess that only one view can be Target so whole logic can be even
simplified.
Other point is that I'm not sure how enabling more view to be editable
change whole logic here, but that will not be before 1.7.
> Best wishes.
> Dmitry.
Oto

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2781950

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-06-30 22:43:17 CEST