[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suspicious duplication

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 30 Jun 2011 19:00:51 +0200

On 30.06.2011 11:21, Dmitry wrote:
> Hey.
>
> Currently CBaseView::HasNextInlineDiff() and
> CBaseView::HasPrevInlineDiff() are implemented identically. To me
> that makes no sense and maybe it is an error. Even if it is how it
> should be there's no reason to have two identically implemented
> nontrivial functions - either one should call another instead or both
> should call a third function named something like
> "HasInlineDiffs()`.
>
> Duplication was detected using PVS-Studio static analysis tool.

Ups, that function is broken.
I'll try to fix this soon.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2781930
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-06-30 19:01:17 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.