[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suspicious conditional

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 29 Jun 2011 20:09:12 +0200

On 29.06.2011 09:19, Dmitry wrote:
> Hey.
>
> Currently CPicture::SetActiveFrame() reads:
>
> UINT prevframe = frame;
> prevframe--;
> if (prevframe< 0)
> prevframe = 0;
>
> here prefframe is unsigned, so it can't be< 0. This defect was detected using PVS-Studio static analysis tool.

Fixed in r21635.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2780562
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-06-29 20:09:23 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.