Suspicious code in a conditional statement

Hey.

Currently svn_error_t * getallstatus(void * baton, const char * path, const svn_client_status_t * status, apr_pool_t * /*pool*/) contains the following code:

if ((sb->SubStat->Author[0] == 0)&&(status->repos_relpath)&&(status->repos_relpath))

here there're identical conditions on the left and on the right of "&&". Perhaps one of those checks is misspelled or unneeded. This defect was found with PVS-Studio static analysis tool.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2778130

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-06-27 16:23:01 CEST