Re: [T-Merge patch] syncing code for views

On 07.04.2011 00:11, Oto BREZINA wrote:
> Part3:
>
> prepend object name to simplify comparison/extraction common code
> use HasSelection() where aplicable
> Bottom: reorder viewstate triplet to order as used in LeftView and RightView
> Left: rename temporary variable from state2 to state
> Right: move SetModified out of for cycle

Committed in r21118.

> Note: by comparing LeftView, RightView and BottomView you can get nice overview about common part and differences
>
> In LeftView there are two BuildAllScreen2ViewVector(); RecalcAllVertScrollBars();, while in RightView on same place there are not those calls. Also not sure if they may be outside if (e.g. m_pwndLocator->DocumentUpdated(); is affected).

Fixed in r21119.

> sometime if (m_pwndBottom->IsViewLineConflicted(viewLine)) is used while on other places not.

It's used whenever the bottom view is visible. Or do you see another place?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2717738
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].