[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [T-Merge patch] syncing code for views

From: Oto BREZINA <otik_at_printflow.eu>
Date: Thu, 07 Apr 2011 00:11:55 +0200

Part3:

prepend object name to simplify comparison/extraction common code
use HasSelection() where aplicable
Bottom: reorder viewstate triplet to order as used in LeftView and RightView
Left: rename temporary variable from state2 to state
Right: move SetModified out of for cycle

Note: by comparing LeftView, RightView and BottomView you can get nice overview about common part and differences

In LeftView there are two BuildAllScreen2ViewVector(); RecalcAllVertScrollBars();, while in RightView on same place there are not those calls. Also not sure if they may be outside if (e.g. m_pwndLocator->DocumentUpdated(); is affected).

sometime if (m_pwndBottom->IsViewLineConflicted(viewLine)) is used while on other places not.

-- 
Oto BREZINA, Printflow s.r.o., EU
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2717483
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-04-07 05:31:58 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.