[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Improvements for changes for "Changes files" dialog

From: Hans-Emil Skogh <Hans-Emil.Skogh_at_tritech.se>
Date: Tue, 29 Mar 2011 07:10:07 +0000

>> Sven, really nice to see some contributions from the
>> TortoiseGit-project as well. Thanks a bunch!
...
>>> All this is already working for a long time on trunk.
>> ...almost. :-)
> It is for me. Please check again.

Ah. I see where the confusion is. You are looking at the CfM and Log dialog context menus. The suggestions/patches regards the "Changed Files" context menus.

How I get there: Open the log dialog. Ctrl-select two different revisions from the list. Right click one of them. Select "Compare revisions". Behold the "Changed Files" dialog.

> Operations in the CfM dialog and the log dialog, even
> if they do the same (from the users perspective) are not the same,
> especially when it comes to speed. Some operations in the CfM dialog
> don't require repo access (meaning: use a slow network to get the
> required data) and those should be on top.

I fully understand and agree. I do however think that the "Log Messages" dialog and the "Changed Files" dialog context menus would benefit from being more consistent with each other.

So, in other words: The two context menus I'm comparing are:
1.) Right click on a file/path in the list located in the bottom of the "Log Messages" dialog.
2.) Right click on a file/path in the "Changed Files" dialog. (Not to be confused with the CfM a.k.a. "Working Copy" dialog.)

I hope my suggestions make more sense now. :-)

>> I'd propose to make the following changes to the "Changed Files"
>> context menu:
>>
>> A.) Change the top three items to be consistent with the top three
>> items from the context menu from files in the log dialog. Today
>> naming and order differ. New top three: "Show changes"(bold), "Blame
>> changes" and "Show changes as unified diff".
>>
>> B.) Add "Show log" item.
>>
>> C.) Perhaps add the "Create patch" option. But in that case, for
>> consistency, add it both to the log dialog file context menu as well
>> as to the Changed Files context menu.

And: Maybe the name of the "Changed Files" dialog should be changed to something not so easily confused with the CfM dialog?

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2714914

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-03-29 09:10:23 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.