[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Improvements for changes for "Changes files" dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Mon, 28 Mar 2011 18:40:19 +0200

On 28.03.2011 10:17, Hans-Emil Skogh wrote:
> Sven, really nice to see some contributions from the
> TortoiseGit-project as well. Thanks a bunch!
>
>>> 1. show icons in popupmenu in "Changed files" dialog See:
>>> http://repo.or.cz/w/TortoiseGit.git/commitdiff/05773c0195ca24bd2a099d3d8e91ebc04b493e3d
>
>>>
> Done on TSVN trunk.
>
>>> 2. Allow to show log for files in "Changes files" dialog See:
>>> http://repo.or.cz/w/TortoiseGit.git/commitdiff/8f624fd8038aff1ba6b0b1021ea2becbd93c6eb9
>
>>>
> Not available on TSVN trunk.

It is for me here. Between "revert" and "blame".

>
>>> 3. I'm missing a "create patch" (diff) option.
>
> Also missing on TSVN trunk.

Between "Get Lock" and "Properties".

>
>>> 4. A diff produces temp-files with .tmp extention which could
>>> lead to a text-diff instead of a picture-diff. Like:
>>> http://repo.or.cz/w/TortoiseGit.git/commitdiff/1325c5f745c673b564b9c3c8a9a904d0c51fd82c
>
>>>
> Done on TSVN trunk.
>
>>> 5. The filename isn't really helpful if you use an other
>>> diff-tool Like:
>>> http://repo.or.cz/w/TortoiseGit.git/commitdiff/f6ff1506ad356f5658635286d132d3015bf2057d
>
>>>
> Pretty much done on TSVN trunk. I guess the file name could be a tad
> bit prettier, but today it really contains all information you need
> I'd say.

If you don't like that the full path is shown, use the "filename" column
instead.

>
>> All this is already working for a long time on trunk.
>
> ...almost. :-)

It is for me. Please check again.

>
> I'd propose to make the following changes to the "Changed Files"
> context menu:
>
> A.) Change the top three items to be consistent with the top three
> items from the context menu from files in the log dialog. Today
> naming and order differ. New top three: "Show changes"(bold), "Blame
> changes" and "Show changes as unified diff".

Not a good idea. Operations in the CfM dialog and the log dialog, even
if they do the same (from the users perspective) are not the same,
especially when it comes to speed. Some operations in the CfM dialog
don't require repo access (meaning: use a slow network to get the
required data) and those should be on top.

>
> B.) Add "Show log" item.
>
> C.) Perhaps add the "Create patch" option. But in that case, for
> consistency, add it both to the log dialog file context menu as well
> as to the Changed Files context menu.

These are already done. If they don't show up for you, you have to
provide info on your setup/files your right-clicked on/...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2714796
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-03-28 18:40:30 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.