[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - wrong casts, no cleanup in destructor

From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 07 Feb 2011 09:58:11 +0300

Hey.

>>  That code is copied from CShellExt in TortoiseShell, where the class
>>  is indeed inherited from all those interfaces. static_cast works
>>  there - I copied that code into a separate project to test. If
>>  static_cast was used initially the compiler would prevent such
>>  unfortunate use of copy-paste.
> Ups. You're absolutely right.
> Fixed in r20823.

Attached is an untested patch with more of the same in all other COM servers.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2702599

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-02-07 07:58:20 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.