Re: Patch - leaking file handles and minor issues in ContextMenu

On 26.01.2011 07:14, Dmitry wrote:
> Hey.
>
>> But I tweaked your patch a little bit: I'd like to declare buffers
>> outside a loop since not all compilers are smart enough. Declaring
>> them inside the loop can lead to repeated stack
>> allocations/deallocations of the buffer for every loop run. Just to
>> be safe here, I'd like to do that outside the loops.
> Allocation/deallocation of TCHAR[] on stack is at most a single
> processor instruction (adjustment of "stack top" register), nothing
> more and most compilers will just allocate space for all stack
> variables of the function at once - one huge frame for all stuff.

Not all compilers are so effective. I have used many compilers for
microcontrollers which are really terrible in that respect.

> Also it is much more reliable if the buffer is reinitialized before
> each use - that's the number one reason I moved the definition into
> the loop body.

Error checking the DragQueryFile call is better here anyway:
see r20770.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2700669
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].