Suspicious code in AppUtils

Hey.

Currently CAppUtils::StartExtMerge() contains the following code:

com = CPathUtils::GetAppDirectory() + _T("TortoiseMerge.exe");
if (com.IsEmpty())
{
      com = CPathUtils::GetAppDirectory();
      com += _T("TortoiseMerge.exe");
}

which looks insane. First, how could a concatenation of anything with a non-empty string literal produce an empty string? Second, even if that happens why compute and assign the very same concatenation again?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2699529

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-01-21 08:01:07 CET