[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch - prohibited operations should not have implementations

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 21 Dec 2010 11:21:35 +0300

Hey.

Many classes in TSVN are non-copyable by design. They have copy constructor and assignment operator private. Yeat some of them have those operations with empty implementation:

class Class:
private:
    Class(const Class&){}
   void operator=(const Class&){}
};

this is dangerous - those implementations might be accidentially called from within the same class member functions and make the program malfunction.

Attached is an untested patch that addresses this. If it breaks the build it will mean that it is actually effective.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2692348

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2010-12-21 09:21:45 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.