[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - code duplication and minor problems in Log dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 08 Dec 2010 20:47:03 +0100

On 07.12.2010 14:48, Dmitry wrote:
> Hey.
>
> Attached is an untested patch that addresses issues in Log dialog:
> - code duplication
> - too wide scope of variables
> - too deep nesting
> - risk of undefined behavior if buffer is completely used
> - wrong size of buffer passed into function

Thanks!
Committed in r20585.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2688872
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-12-08 20:47:23 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.