Re: Suggestion: the characters that do not allow committing.

Hi,

On 5 September 2010 13:26, Serge Tumanyan <tumanyan_at_mail.ru> wrote:
> Stefan,
>
>>> 2. There is no ability to prevent a commit/import/branching with an error
>>> message and returning back to commit/import/branching dialogue or at
>>> least I
>>> was unable to find this in the documentation.
>> Yes, there is: write any error text to the console error stream and
>> return something else than 0 as the exit code of your hook script.
>
> I have played a bit with this and encountered some additional problems here:
> 1. Returning a non-zero result works as expected in terms of stopping the
> commit process, but I am getting the dialogue with the commit error and
> nothing else - commit dialogue is not opened again for fixing the problem in
> a comment.

TSVN Settings, General->Dialog 2: 'Reopen commit and branch/tag dialog
after a commit failed'

> 2. Ok, I decided to do this through using TSVN command line and found out
> that I am unable to close the current dialogue with an error and even to
> check if this a dialogue with an error or a dialogue with success if it was
> started from the context menu and not from the script at least without using
> something undocumented.
> 3. I am unable to say inside the script what was a dialogue that has caused
> a mistake - either it was a commit dialogue, or it was an import one or even
> the branch/tag one, so I do not know what dialogue should be reopened again,
> no information is passed to the script about this.

See above, let TSVN decide what to do based on the error return from
the hook script.

> 4. There is no ability to get the non-committed message that was discarded
> to insert it back into the dialogue that was broken before for the user to
> modify it to the correct state.
>

Yes, check the 'recent messages' button on the commit window, it
should have the latest commit messages, also for failed commits.

-- 
Regards,
Jean-Marc
--
.       ___
.  @@  // \\      "De Chelonian Mobile"
. (_,\/ \_/ \     TortoiseSVN
.   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
.   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2655652
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].