Re: New patch

On 28.05.2010 08:18, Hans-Emil Skogh wrote:
> >> I was thinking about the improvements that we discussed in this thread:
> >>
> http://groups.google.com/group/tortoisesvn-dev/browse_thread/thread/7ac3f7760fa2083b/cb30a3544a849978
> > http://code.google.com/p/tortoisesvn/issues/detail?id=34
> > http://code.google.com/p/tortoisesvn/issues/detail?id=35
> Much better!
> One little thing:
> - The "Patch all items" button overlaps the little "resize-grip" in the
> lower right corner. Maybe disable the drawing of the "resize-grip" or
> add a margin to the window (a'la the log dialog for example).

Strange, I don't see the resize-grip. Even on my XP VM it doesn't show.
But I'll add some more code to really disable the grip.

> I still feel that it's confusing that the "File patches"-window is the
> child of the TortoiseMerge window. I understand why, but it feels backward.
> I would excpect the "File patches" window to be a regular stand alone
> window, that swpawns TortoiseMerge instances if I want to preview a
> file. In the same way as the "Changed Files" dialog works. This would
> make the patch feature look/feel/work more in line with the rest of TSVN
> and would also remove the current confusion about what "X" to press to
> abort the patch and what "X" to press to close the patched file preview.

If it would spawn separate TMerge instances, imagine the slowdown and
memory use if the user clicks on "patch all".

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2614673
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].