Re: Crash in nightly: Log Message dialog (Also: 100% method to crash TortoiseProc)

On 10.05.2010 17:04, Hans-Emil Skogh wrote:
> > If I select show log on a single file, make sure that "Show only affected
> > paths" is checked, select a revision that have more then one file
> committed
> > and then double click the file the Log Message dialog crashes.
> Ok. Managed to catch this one in the debugger. Didn't get that much
> savvier though...
> What I can make of it is that a WM_LBUTTONDBLCLK (0x203) message is
> passed to CLogDlg::PreTranslateMessage(). The message looks good and is
> passed on. When the message arrives at CResizableDialog::WindowProc() it
> has been translated into a WM_NOTIFY (0x4E) message. This message has a
> pointer to a NMHDR structure as lParam. The code field of this structure
> is 0xfffffffd. This is then passed on and then triggers the following
> crash (callstack and crash message from different runs):
> Unhandled exception at 0x7c812afb in TortoiseProc.exe: Microsoft C++
> exception: std::out_of_range at memory location 0x0013c710..
> When I uncheckn "Show only affected paths" and doubleclick everything
> looks pretty much identical except for that NMHDR.code = 0xfffffff0.
> That's the difference that I can spot, but no idea on why this happens...

Fixed in r19493.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2606937
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].